Noitidart / Chrome-Store-Foxified

Point and click to install extensions into your browser from the AMO, Chrome Web Store, Microsoft Store, or Opera Addons websites.
https://addons.mozilla.org/en-US/firefox/addon/chrome-store-foxified/?src=github
Mozilla Public License 2.0
362 stars 55 forks source link

Signing failed. Not logged in AMO. (And needs better display to user of error when install fails) #46

Open thrdroom opened 7 years ago

thrdroom commented 7 years ago

I tried to install the chrome extension called "Signal Private Messenger" without any success.

When i hit the option: "Sign and Install" i get the error: "Signing failed. Not logged in AMO." even when i am logged in into my AMO-Account.

When i hit the option: "Temporarly Install Unsigned Addon" nohing happens, no errormessage.

And when i save the addon as XPI-File and try to install it manually i get the error that: "This addon cant be installed cause its damaged"

Noitidart commented 7 years ago

I tested this out. I got the signed out error but I was indeed signed out.

I went to addons.mozilla.org (AMO) and logged in, please ensure this is the case for you, when you go to AMO do you see your user name at top? as in my screenshot here:

Noitidart commented 7 years ago

I am able to reproduce the failed installation/corrupt XPI. The error logged to console is this:

1476041036769 addons.webextension. ERROR Loading extension 'null': Reading manifest: Error processing permissions.2: Expected string instead of {"fileSystem":["write"]} Log.jsm:753

Invalid match pattern: '[object Object]' MatchPattern.jsm:52

It seems Firefox WebExtensions API does not support this API. It's not even listed here - https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Chrome_incompatibilities

Noitidart commented 7 years ago

So one thing I definitely need to do, is on fail of temp install, or even normal install, it should report the error. I'll mark this as a bug that needs fixing.

Please let me know if you can't get that "Signed out" issue to go away though. Are you using it in private mode?

Noitidart commented 7 years ago

@thrdroom is it ok we rename this bug/issue to "better error message support" and then we can discuss the issue with Signal addon compatibility in issue #18

And if the sign in issue is there even when you see yourself logged in as in above screenshot, or if you are in private mode, then we should probably create a separate issue topic for that. I really appreciate you joining me on Github for this.

thrdroom commented 7 years ago

@Noitidart Im absolutely ok with renaming this issue, and discussing the issue with Signal addon compatibility in issue #18

sblask commented 7 years ago

Got the same problem with Next Page

sblask commented 7 years ago

... and Scrollbar Anywhere

Noitidart commented 7 years ago

Thanks @sblask for the bump with example! Did your browser console show some errors like the one above? I am thinking Next Page is using some unsupported keys in manifest.

sblask commented 7 years ago

I did not see errors in the console.

Noitidart commented 7 years ago

Interesting, i'll dig into it and report what I find.

nerotic commented 7 years ago

I'm having this problem as well. Login confirmed and I'm in the loop.

Noitidart commented 7 years ago

Thnks @nerotic for the note, in the new webext version this will work better. But the problem in the webext version is I'm having the hardest time auto installing the downloaded addon.

claytonrcarter commented 7 years ago

Is there any workaround for this while we wait for the webext version? Can we download an extension & sign it manually through the AMO interface, then use Chrome-Store-Foxified to install?

I'm trying to install Vue.js Dev Tools via these instructions but I get stuck at "Signing failed. Not logged in AMO." (I have an account at AMO and have logged in there just fine.)

Noitidart commented 7 years ago

@claytonrcarter - yes you can click on "Download CRX", then you can go to AMO and sign it.

Noitidart commented 7 years ago

@claytonrcarter - do try to use it though with private mode settings off - https://github.com/Noitidart/Chrome-Store-Foxified/issues/36 - it should work.

claytonrcarter commented 7 years ago

Thank you! I had third party cookies disabled. (My remember history was set to "use custom settings for history".) Setting history back to "Rememeber history." fixed it.

Noitidart commented 7 years ago

Awesome! I hope to fix that in the webext version :)

Noitidart commented 6 years ago

i think this was fixed in v3 - webext version - may you please try it out and verify? https://addons.mozilla.org/en-US/firefox/addon/chrome-store-foxified/

sblask commented 6 years ago

I stopped using Firefox...

beliefless-dogmasless commented 6 years ago

It's about the history, which is not retained: about:preferences#privacy check "remember history", then hit 'Retry Now' at the level of the extension(not working) or go to the page to agree to: https://addons.mozilla.org/en-US/developers/addon/agreement/