Open KoastDev opened 7 years ago
Thanks KoastDev for this topic. After selecting, do you scroll the wheel? I didn't think of this, I was selecting text and moving the mouse to the bottom/top to scroll, thanks for bringing it up. I'll address this in next version (rewriting it so i can bring back onto AMO as a webextension).
Yeah the recording of mouse combination is something I had to do because I support all buttons and all mouses. Each button might have a weird button code sent. So I couldn't hard code it. I need to come up with a more intuitive way to "finish the recording". This is the problem no? Finishing the recording? As right now we have to move mouse outside and then release buttons.
I think I got it for the recording. How about when the first button that was downed comes up, then completes the recording? I will allow the same button to be pressed if the time is within "multi-click" time, (so by default 300ms), so it will record as a multi click. But if any other button is pressed within 300ms it clears the previous recording.
Marking as bug for the "text select and scroll wheel when nothing is on that gesture".
You are correct with both. Your solution for the second issue sounds good.
Thanks! May we please keep this open and then I can keep updating it from commits to code :) and we'll close when the solution lands :)
Sorry for that I'm new to github. I wasnt even sure if I should post two issues in one topic or open one for each.
No sorries please. I really appreciate it! :)
I wasn't sure if i should create new topic for each issue.
Despite removing all 3 Zoom functions i am unable to select text and scroll at the same time.
Creating mouse combo is kinda weird/hard/uncomfortable it might be better to list possible buttons and type in the combo you want or something.