Noitidart / Profilist

ff-addon: Profile manager for Australis
https://addons.mozilla.org/en-US/firefox/addon/profilist/?src=github
34 stars 1 forks source link

No hamburger burg menu :( #39

Open L-a-n-g-o-l-i-e-r-s opened 8 years ago

L-a-n-g-o-l-i-e-r-s commented 8 years ago

Hey there,

If I could contribute I would, just wondering how things are progressing, I tried building the latest extension and there isn't any burg menu. Was wondering if it's still a priority since it's a bit of a deal breaker.

Thanks for your hard work!

Noitidart commented 8 years ago

I really appreciate your thoughts on trying to contribute. But you testing my addon and providing feedback with this topic is the best contribution you can give! Thank you! :)

What version are you using? The latest beta I uplaoded - https://addons.mozilla.org/en-US/firefox/addon/profilist/versions/beta - is 3.0b4 - it has a toolbar button there, when you click it, it opens the tab with the menu.

Firefox is moving to all HTML, so I created this new version in HTML. The HTML future is at least a year away though. So in v3.1 I plan to add the funcitonality to this hamburger menu.

L-a-n-g-o-l-i-e-r-s commented 8 years ago

3.05b, no burg and no toolbar button in edit or otherwise. Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:45.0) Gecko/20100101 Firefox/45.0

Noitidart commented 8 years ago

Whoa thats very weird.

When you click the hambruger menu you don't see the toolbar as seen in my screenshot:

Clicking that, will open up a pinned tab to about:profilist?html. If you dont see that toolbar, can you please paste this URL into your url bar and see if it works.

Also what version of Firefox are you using? Nightly?

L-a-n-g-o-l-i-e-r-s commented 8 years ago

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:45.0) Gecko/20100101 Firefox/45.0

No I don't see that toolbar, but perhaps another extension is causing problems. I do have an extension that adds a restart button in the burg menu near the question mark.

Noitidart commented 8 years ago

I love that restart addon I use it too :)

That addon for sure shouldn't mess it up.

That's very interesting. I'm using Fx46 and it works fine.

Can you try navigating to about:profilist?html please

L-a-n-g-o-l-i-e-r-s commented 8 years ago

The address isn't valid

The URL is not valid and cannot be loaded. :

Noitidart commented 8 years ago

Ah that's a big problem. Can you please try to install the xpi from here: https://github.com/Noitidart/Profilist/tree/bug1249929

L-a-n-g-o-l-i-e-r-s commented 8 years ago

Tried removing, restarting and reinstalling from that twice and still no dice.

about:profilist doesn't even work.

Noitidart commented 8 years ago

Aw man thanks very much for your testing, I'll look into this closer.

To install the xpi, were you going to about:debugging and then clicking "Load Temporary Addon"?

L-a-n-g-o-l-i-e-r-s commented 8 years ago

No, I have no issues with unsigned extensions and installation. I am using two right now unsigned that I compiled working fine on 45.

Noitidart commented 8 years ago

Ah ok thanks for that, I'll start digging at this. Thanks very much for this feedback!

L-a-n-g-o-l-i-e-r-s commented 8 years ago

I just tested via your method and it's still not displaying. I'll try disabling all my extensions and loading this one.

Noitidart commented 8 years ago

Can you install this addon to enable developer preferences - https://addons.mozilla.org/en-US/developers/addon/devprefs/ - and then install profilist and then paste here what is dumped to the browser console please?

Please install the one from that bug repo.

L-a-n-g-o-l-i-e-r-s commented 8 years ago

I don't know why but that link wants me to log in, not going to happen. I'm not going to sync my data with mozilla sorry. Did you link me to the right extension? which bug repo? the one from earlier?

Noitidart commented 8 years ago

This repo here please - https://github.com/Noitidart/Profilist/tree/bug1249929 There is Profilist.xpi in that repo. Please try that one.

Noitidart commented 8 years ago

Ohhh the dev prefs addon is here - https://addons.mozilla.org/en-US/firefox/addon/devprefs/ - yeah i posted wrong link haha shoot

L-a-n-g-o-l-i-e-r-s commented 8 years ago

http://pastebin.com/h6qH5UFv

Noitidart commented 8 years ago

Oh very interesting, it's getting stuck at step0.

Was there anything after that worker: step0 line?

You should have seen something starting with msgFrom_fsReturnIconset_onPageReady

L-a-n-g-o-l-i-e-r-s commented 8 years ago

http://pastebin.com/taXGWBcJ clicked dropped down arrows for more detail.

Noitidart commented 8 years ago

That's real interesting. I don't know why its getting stuck at step0 I'll dig into this.

L-a-n-g-o-l-i-e-r-s commented 8 years ago

Yes, if I recall for some reason any version that I installed after a specific 2.0 version wouldn't work at all for my FF.

Noitidart commented 8 years ago

Ohhh you had 2.0 installed!! Ok lets do some resetting.

Please go to the the "run dialog" or hit Win Key + R

Then type in %APPDATA%\Mozilla\Firefox

Then delete the profilist_data folder.

Then open firefox from the regular profile manager. By going to "run dialog" again, and then type in firefox -P then exit. That will reset your profiles.ini - then launch up firefox the way you normally do please.

L-a-n-g-o-l-i-e-r-s commented 8 years ago

I had it installed a long time ago but have since made a new profile. I'll see if that file is there. Yeah, no, that folder isn't there.

L-a-n-g-o-l-i-e-r-s commented 7 years ago

This is still an issue in v4 beta when built with xpiler, I cannot access a burg menu, nor can I access it via about:profilist or about:profilist?html. "The address isn’t valid" when even trying to click options via the about:addons options.

New or old profile makes no difference.

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:45.0) Gecko/20100101 Firefox/45.0 (49.01 x64 build now).

Noitidart commented 7 years ago

Hey @L-a-n-g-o-l-i-e-r-s ! Thanks for trying out v4, v4 is a total redo and it's going to show in the burger menu. Currently v4 is not hooked up to the profiles.ini file.

Over the weekend there was a big discussion on webextension future which will block all my addons. I'm trying to figure out how I can do this in a future proof work.

L-a-n-g-o-l-i-e-r-s commented 7 years ago

Parker Lewis September 4, 2016 at 5:35 pm

The main thing that holds Mozilla back is add-ons, and that is going to be solved with practically no sacrifice with WebExtensions + native.js. Firefox add-ons can't be ditched, they're too great. Once they have moved to WebExtensions, all the compatibility-breaking tech can be unleashed without damage to the ecosystem.

That includes everything you suggest.

Yes, an API is a serious limitation over total freedom. But like I said native.js will be able to do anything that old-style add-ons can do.

From Bill McCloskey, who is in charge of this at Mozilla:
"I don't think there will be any technical limitations on what sort of XUL or XPCOM access is permitted from native.js."

The 'limitation' on native.js only concerns ease of development. Instead of minding your own business as a developer, doing your own thing and publishing your add-on, you will have to build a native.js module that will be subjected to more careful review than regular add-ons. And Mozilla and other add-on developers will be looking at your native.js module in case it breaks, so even if you die or disappear they can fix it.

If it was like you said, indeed this would be a tradeoff. But it's not, we're only trading some inconvenience versus the good things talked about here and there in this article's comments."

I chopped it up a bit, it was some comments on ghacks, honestly, it made me a lot less angry and it seemed logical, I don't know what happened over the weekend, but it sounds like native.js might be the way to go? http://www.ghacks.net/2016/09/04/the-state-of-mozilla-firefox/

Noitidart commented 7 years ago

Thanks for sharing that info! What caused the situation was the native.js implementation landed and it was nothing like what was proposed - https://wiki.mozilla.org/WebExtensions/Experiments#Other_proposals

:( may you email me at noitidart@gmail.com and I'll forward you the email chain of the discussion.

L-a-n-g-o-l-i-e-r-s commented 7 years ago

That is very disappointing to hear!

Noitidart commented 7 years ago

I started v4 last week, and now I have to start v5 which is a webextension. No burger menu possibility :'(

L-a-n-g-o-l-i-e-r-s commented 7 years ago

Can we at least drag an icon into the burger menu?

Noitidart commented 7 years ago

Yes it will be an icon in the toolbar, clicking it will open a new tab. I can't put the menu inside a panel as resizing the height of the menu dynamically really messes with the panel. :(