When go to customize without having opened menu panel, "Profiles Loading..." hangs

[yajd]

As part of my customizing the browser, I removed the hamburger menu button from the nav bar. I enter the Customize Toolbar menu by right-clicking the toolbar and selecting Customize. When you do this, the overlay created by your addon is greyed out, and doesn't work. Using the hamburger menu and it works. You can try that yourself. Possibly you could open a new issue for that.

@grbradt can you please help me understand this.

I tried hard but I can't figure out how to remove the hamburger menu button from navbar. In customize mode/tab the overlay should be greyed out.

[ghost]

Hi, Sure, first I apologize if I state something obvious here! The nav(igation) bar is the toolbar which contains the url and search bar. The 'hamburger' menu button is the new button at the far right of the nav bar, it is 3 horizontal lines, and people are calling it the hamburger. When you click the hamburger, there should be (as I recall, I removed the button a long time ago) a Customize item at the bottom of the menu, below your overlay and the Sync item. Click Customize to open the Customize Toolbar window. There is another way to get to that window. I use the second method, since I removed the hamburger already. Right-click on an empty part of your nav bar (or menu bar, if that toolbar is showing) and a context-menu will appear, with the last menu item as Customize... Click that and the Customize Toolbar window opens, as well as the menu that appears when clicking the hamburger. When I do that, I see Loading profiles.... in the menu, greyed out and not working.

Regards, George

On Wed, Apr 30, 2014 at 4:44 PM, yajd notifications@github.com wrote:

As part of my customizing the browser, I removed the hamburger menu button from the nav bar. I enter the Customize Toolbar menu by right-clicking the toolbar and selecting Customize. When you do this, the overlay created by your addon is greyed out, and doesn't work. Using the hamburger menu and it works. You can try that yourself. Possibly you could open a new issue for that.

@grbradt https://github.com/grbradt can you please help me understand this.

— Reply to this email directly or view it on GitHubhttps://github.com/Noitidart/Profilist/issues/5 .

[Noitidart]

Ah I see now. The obvious stuff was very important when it comes to tiny details like this.

Quick question: This only happens if you install the addon, or startup the browser, and do not click the hamburger icon, [so panel has not opened yet], and you go to customize. So in other words, if you open customize tab BEFORE ever opening the panel you will see "Loading Profiles..."? Can you try opening the panel first then going to customize, it should probably not say "loading profiles".

I was able to replicate this bug.

It should be greyed out so thats not the problem. It just shouldn't say Loading when its not. A bug here though, is while it is grayed out, and reads "Profiles loading" if you hover over it with mouse it changes height, this needs to be fixed as it should be disabled.

[ghost]

Yes, you've got it. Some time ago, I went into Customize, and dragged the hamburger off the nav bar, and dropped it into the Customize window. (By the way, I don't recommend you do this if you want to put it back again, as it may lose some functionality). So when I installed your addon, hamburger was gone, and I always got "Loading Profiles...", greyed out when doing it the other way. I set up a new profile (not temporary!) and installed Profilist. Then clicking hamburger, I see the current profile properly. But if I go into Customize the other way (you don't need to remove hamburger, btw) it will show the current profile, but it is still greyed out, and not functioning. Hope this helps.

[Noitidart]

Thanks this helps very much. The greyed out behavior is correct behavior. As the sync button is also greyed out/disabled. What do you think?

The hover and showing "Loaidng Profiles" forever is bug behavior and I'll need to fix that.

Btw how on earth did you get rid of the hamburger (its actually a tri strip menu haha) icon? I can't do it no matter what I try lol

[Noitidart]

Also another btw, how do you open the panel with the hamburger/menu icon gone? Profilist doesn't work without being able to open the panel. Do you have anothre icon that opens the panel?

[ghost]

Ah, Ok, I didn't realize Sync was also disabled, I don't use that. So, that means I can't use your addon right now, because I don't want to put hamburger back. I think I saw a comment that you were considering including a toolbar button with your addon, so I guess I will wait for that. After you are in Customize mode, you just drag any toolbar buttons around, and put them anywhere you want, usually to another spot on any toolbar. This includes the hamburger (but I seem to recall it returns to its original location on browser restart). But you can also drop them in the Customize window, or the hamburger menu itself. Then they are gone, but you can always drag them back to a toolbar later.

[ghost]

Ha, your last comment got in while I was typing.

[ghost]

I restored the old menu bar, so didn't need hamburger menu.

[Noitidart]

Ahhh I see. This addon here called Profile Switcher adds a similar feature to the File menu. I don't want you to wait especially if we never make an icon. Man it's so funny you contributed more than a person who actually uses the addon does. Your feedback was extremely valuable man!

ps: theres gotta be some addon or theme allowing you to drag the hamburger, i cant figure it out haha

[ghost]

No problem. Perhaps I'll hack on the code and add a button myself.

[Noitidart]

Hey man I was thinking why don't you just add back the hamburger/tristripe button?

[ghost]

Actually, I wanted to test a new dark theme specifically designed for Australis, so I have set up a new profile for it. I liked it so much, I am making it my new default profile. I am keeping the new menu button on it, so I now have your addon installed and working. It would be cool if I could create and launch a temporary profile like the standalone Profile Manager does. I use that feature a lot. Also, when Profilist creates a new profile, it prompts whether you want to add itself to the profile. I have a base set of addons I like to add when creating a new permanent profile, ABP, NoScript etc. I have these addons bundled into one large xpi. It might be nice if Profilist would prompt to install that instead? Maybe I can customize your code to do this. I see you have developed a lot of addons, good job!

[Noitidart]

Oh super news man! I'm so glad you get to use it.

I'll add that as a feature request: "A way to launch a profile as temporary profile" :)

Ah cool you like that popup of installing Profilist? I thought it was a good idea. :)

Sure I can make you a custom version which points to your xpi. Whats the path to your xpi?

[ghost]

Hi, Thanks! C:\Users\GeoNotebook\Documents\Cleo.new profile.xpi Maybe I should fork your repo to pull in your future updates. I'm used to Mercurial and SVN, I'll give it a try.

[Noitidart]

Yeah man can you please click "Fork" on my Profilist repository and then add me as contributor I'll help you customize it. :) If you want to use mercurial I'll make an account there. :)

[ghost]

Forked at https://github.com/grbradt/Profilist I will try git, maybe learn something.... Thanks for your help! Familiar with basic Javascript, but haven't learned some of the newer features like promises and arrow functions.

[Noitidart]

Ok finally fixed!