search

Noitidart / Smart-Zoom

Firefox Addon: Simulates the smart zoom of mobile devices and tablets on desktop. Instead of double tapping though, click and hold to smart zoom into the article. Inspired by jmiller29.
https://addons.mozilla.org/en-US/firefox/addon/smart-zoom/
5 stars 4 forks source link

Preferecnes needed. Hold down time #5

Closed Noitidart closed 10 years ago

Noitidart commented 10 years ago

Preferecnes needed. Hold down time. Thanks @difabor for bring it up.

difabor commented 10 years ago

Oh,but it is a headache - to create Preferences. If an image can be detected and the addon will use right button instead of left one - there is no need in preferences, isn't?

Noitidart commented 10 years ago

It's not big thing anymore with inline options. We need an setting for the the hold down time, as you mentioned that if you hold down too long its zooming in even though you just want to highlight. Right now it's set to 300ms, people may want to increase the long hold time to like 600ms or more, what do you think?

difabor commented 10 years ago

If it is not a big thing with inline options it will be good to give people to change hold time.It also can be done via about:config - to define the hold time variable in about:config and tell users how to change it. It will be easier for you to implement this-- Livejournal: http://difabor.livejournal.com/Facebook: http://www.facebook.com/boris.raifler   07.05.2014, 04:25, "Noitidart" notifications@github.com:It's not big thing anymore with inline options. We need an setting for the the hold down time, as you mentioned that if you hold down too long its zooming in even though you just want to highlight. Right now it's set to 300ms, people may want to increase the long hold time to like 600ms or more, what do you think?—Reply to this email directly or view it on GitHub. 

difabor commented 10 years ago

Regarding preferences - if you intend to implement preferences - in addition to hold time it is desired to add "Images only mode" - there are some actions in other addons that work on long click, for example "Open link in background tab" etc. that might conflict with this Zoomr

Noitidart commented 10 years ago

thanks man for that i'll implement that

On Thu, May 8, 2014 at 8:43 AM, difabor notifications@github.com wrote:

Regarding preferences - if you intend to implement preferences - in addition to hold time it is desired to add "Images only mode" - there are some actions in other addons that work on long click, for example "Open link in background tab" etc. that might conflict with this Zoomr

— Reply to this email directly or view it on GitHubhttps://github.com/Noitidart/Zoomr/issues/5#issuecomment-42566047 .

Noitidart commented 10 years ago

ok preferences imploemented and specifically for hold time

https://github.com/Noitidart/Zoomr/commit/71d7adc9a7598ab47f366924c1c2e044efe4eef3

i didnt add the images only mode yet as that requires work in the main code i

test it out man, you know how to install with GitHub Extension Installer? (https://addons.mozilla.org/en-US/firefox/addon/github-extension-installer/)