search

NojdarTaho / Personal-game-library

https://646ea586adf0ce40e6b18673--celadon-squirrel-7c8af5.netlify.app/
0 stars 0 forks source link

General Code Feedback #4

Open crevulus opened 1 year ago

crevulus commented 1 year ago

Hi Nojdar.

This is not an issue, I have only opened an issue so I can leave some notes about your code.

I love this app! I think it looks fantastic, and you have stuck to a difficult styling theme. Plus the data flow and scripting is very good.

A couple of things you might want to try changing, but you do not have to change any of them:

  1. You have two different ways of showing the dropdown menu: either by clicking in the JS or hovering in the CSS. Best to just have one method.
  2. Your css file is very long. It will be easier to manage (and style) if you break it up into smaller files.
  3. Your cut-off border radius style (where you used clip-path) is great on desktop but not on mobile. Maybe try only applying that style in mobile.
  4. Only your landing page (the Game Genres route) you have a large blue div that pushes all of the content down. this makes the page look blank. Maybe you can remove this? Or set it to be a smaller height - again you can do this for mobile-only if you wish.
  5. You already have a good component structure, but maybe you can break more UI elements into components in order to make the code more manageable. e.g. whenever you use a .map function in your JSX, if you are returning an element with two or three elements in it (e.g. a div that contains a paragraph, a link, and a button) then it would be best to extract that into its own component. This will make your JSX much clearer.
  6. Try to be consistent with your data handling. If you make a context that uses localStorage for one functionality, then do the same next time you need localStorage somewhere else. If you do error/loading states on one page, then use them on other pages too (if there are fetch calls)

Again, this is just general feedback that you don't have to listen to! This is a great app and you should be very proud of yourself.

NojdarTaho commented 1 year ago

Thank you immensely for your invaluable assistance in improving my React code. Your feedback on my React homework and your guidance throughout this project has been incredibly helpful. I am deeply grateful of your support and guidance.