search

Nokorbis / ar-command-signs

Minecraft (Spigot) plugin that allows to transform some blocks (Signs, plates and buttons) into a Commands executor
https://www.spigotmc.org/resources/command-signs.10512/
Apache License 2.0
13 stars 10 forks source link

Closing command sign creation without selecting a location causes problems. #31

Closed selfslaughter closed 5 years ago

selfslaughter commented 5 years ago

Using CommandSigns 2.1.0 on Paper 1.14.2.

Type /commandsign create Select "done" without selecting a block. Try to view the broken sign with /commandsign list

Invalid command sign is saved despite having no location data and throws an error if it should appear in /commandsign list.

Error Log - https://pastebin.com/raw/U07VzqP4 Invalid Sign - https://pastebin.com/raw/fwMkc1fp

Nokorbis commented 5 years ago

I'll check that after work. You shouldn't be able to create a command sign without a block selected

Nokorbis commented 5 years ago

Fixed in version 2.0.1 (for Spigot 1.13) and 2.1.1 (for Spigot 1.14)

selfslaughter commented 5 years ago

Yeap, that certainly stops it. Thanks.

Maybe an option to cancel creation would be nice. But beyond the scope of this ticket :)