Nokorbis / ar-command-signs

Minecraft (Spigot) plugin that allows to transform some blocks (Signs, plates and buttons) into a Commands executor
https://www.spigotmc.org/resources/command-signs.10512/
Apache License 2.0
13 stars 10 forks source link

Economy Cost Doesn't Work #37

Closed PrinceOfIonia closed 5 years ago

PrinceOfIonia commented 5 years ago

Hi there, so here is the issue I am having.

The command runs perfectly fine, but will run even if you cannot pay.

Let's say I have $5 and my 'CommandSign' has a set cost of $10, if I right click my CommandSign the command will be preformed anyways, basically making the cost on the CommandSign useless. It even works if you have negative balance or 0 balance.

It does still subtract currency from your account, but it doesn't actually care how much money you have, so if I click on my CommandSign again with $5 in my balance, I would either end up with $0 (If I disabled debts in Essentials) or just end up with negative balance on my account (For this example it would be -$5).

There are no console errors popping up anywhere.

I am running the latest version of Vault, I am also running the latest version of your plugin.

My Minecraft Server Version is 1.14.3

Could someone help me? Maybe I'm just doing something wrong here, thanks!

Nokorbis commented 5 years ago

1) Are you using spigot ? 2) What version of my plugin are you using ? 3) Can you give me the configuration of the sign ?

Nokorbis commented 5 years ago

Can you also check that you do not have the permission : commandsign.costs.bypass

Nokorbis commented 5 years ago

Other question, when you start your server Do you have any of the following LOG appearing ?

PrinceOfIonia commented 5 years ago

I'm using spigot, I'm also using the latest version of your plugin. Not sure how to exactly send you my sign config.

In my server start-up, I did see "Plugin vault detected" and "Vault economy linked with command signs !"

Nokorbis commented 5 years ago

For the config, You can get the id of the sign with the /NCS info command. Then you can go to your /plugins/command signs/configurations folder. And send me your .JSON file (Sorry for cases, on my phone right now)

PrinceOfIonia commented 5 years ago

Okay, I got my config, here you go. SignConfig.zip

Nokorbis commented 5 years ago

What is the plugin you use for your Economy ?

PrinceOfIonia commented 5 years ago

Vault, I have Essentials too.

Nokorbis commented 5 years ago

Vault is the only the API, not the implementation. Weird that Essentials does that. Are you sure it is up to date ?

PrinceOfIonia commented 5 years ago

Yes, latest version. Made to run on 1.14.3 Spigot Servers.

PrinceOfIonia commented 5 years ago

image Just in case, I'll upload an image of my plugins here.

Nokorbis commented 5 years ago

I see MMO stuff, does any of those plugin also have an economy system in it ? Would any of those be the one that actually "pay" the sign ?

PrinceOfIonia commented 5 years ago

Nope, just Vault and Essentials. Reminder that I get absolutely no console errors when using your plugin, or any plugin related to this issue for that matter.

PrinceOfIonia commented 5 years ago

Are you unable to replicate my issue?

PrinceOfIonia commented 5 years ago

Okay, found something new, so it only does this on Admins/OP'd players. Apparently works normal for regular players.

Nokorbis commented 5 years ago

If this is only for Admins, this must be because of the "commandsign.costs.bypass" as I mentionned in my second answer

PrinceOfIonia commented 5 years ago

My bad, I must've forgotten about that when I saw it, I apologize.