Nola-Devs / Nola-Devs-v2

Redesign of the Nola Dev Site
https://noladevs.org
MIT License
18 stars 13 forks source link

Loading-Spinner #46

Closed colinwilliams91 closed 9 months ago

colinwilliams91 commented 9 months ago

Describe the Problem

As a user I would like to be notified that the page is loading when there is an update to the UI that takes time.

References

src/routes/(app)/+page.svelte event list element

    <div class="event-list">
        {#if !data}
            <!-- TODO: Add loading animation here -->
            <h1>Loading</h1>
        {:else}

Describe the Proposed Solution

Create a generic loading component that can be rendered in the above page and be re-used elsewhere in the application.

zablon-oigo commented 9 months ago

Hello, Is the issue still Open? If yes I can tackle this using awesome loaders package to create high-quality 3D loaders that is responsive. I would like to hear your opinion

colinwilliams91 commented 9 months ago

Hey @zablon-oigo thank you for your interest! I'll tag the lead dev, @codingMustache since it involves a 3rd party lib and some design influence. I appreciate your inspiration and consideration re: your solution :)

codingMustache commented 9 months ago

@zablon-oigo what does it look like, out of curiosity? If it matches kind of close to the Figma go for it!

codingMustache commented 9 months ago

Also one more question @zablon-oigo how did you find this project? I'm just curious. Also are you in the discord?

zablon-oigo commented 9 months ago

Also one more question @zablon-oigo how did you find this project?

I searched for good first issue from this site goodfirstissue and your project popped up the first one clicked on it , familiarized myself with the project and decided to ask if the issue is still open or closed

codingMustache commented 9 months ago

Well I'm glad you're hear!!

zablon-oigo commented 9 months ago

Well I'm glad you're hear!!

thank you @codingMustache I'm happy to be here

zablon-oigo commented 9 months ago

@zablon-oigo what does it look like, out of curiosity? If it matches kind of close to the Figma go for it!

Please explain Im not so familiar with figma app trying to click on an Image but im having a hard time to navigate around

figma

codingMustache commented 9 months ago

if you zoom in where the P is, that is what the redesign will eventually look like or at least the aesthetic we're leaning towards. Everything is still a little up in the air but this project is made to replace noladevs hold cmd+scroll to zoom

zablon-oigo commented 9 months ago

if you zoom in where the P is, that is what the redesign will eventually look like or at least the aesthetic we're leaning towards. Everything is still a little up in the air but this project is made to replace noladevs hold cmd+scroll to zoom

well explained let me give it a try

codingMustache commented 9 months ago

Awesome glad to have you on board! Welcome!! Feel free to join the discord too

zablon-oigo commented 9 months ago

@zablon-oigo what does it look like, out of curiosity? If it matches kind of close to the Figma go for it!

Gone through the file and I think what I had in mind to solve this issue will work loader I would like to here your opinion @codingMustache @colinwilliams91

colinwilliams91 commented 9 months ago

@zablon-oigo what does it look like, out of curiosity? If it matches kind of close to the Figma go for it!

Gone through the file and I think what I had in mind to solve this issue will work loader I would like to here your opinion @codingMustache @colinwilliams91

Looks great! Thanks @zablon-oigo. Approved 👍

ghost commented 9 months ago

Ouuuu I love the design! If there's anyway I can definitely let me know!