NolanKingdon / MMM-MoonPhase

Magic Mirror Module that displays the current moon phase
MIT License
54 stars 23 forks source link

Feature Request #35

Closed dcmcshan closed 1 year ago

dcmcshan commented 1 year ago

Hi there. Really enjoying your module. Wondering if you can add a feature to publish the moon phase like weather does so I can use compliments based on the phase of the moon. Thank you!

NolanKingdon commented 1 year ago

Hey - cool idea.

I can add the code to publish the moonphase in this module, but in order for for the moonphase to be picked up by the compliments module, we need to get some changes in to that module as well.

I opened a feature request in the magic mirror core repository to add this feature. If the core magic mirror team also thinks moon phase compliments is cool, I can make the changes in both spots to make this happen.

I'll keep you up to date with how that goes

NolanKingdon commented 1 year ago

I added in the code to emit the notification, but wasn't able to get the code to receive the notification into the default compliments module.

However, I made an exact copy of the compliments module that adds that functionality. To get moonphase related compliments:

  1. Follow the install instructions for the new compliments module
  2. Replace module: "compliments" with module: "MMM-compliments" in your config.js
  3. Follow the instructions for adding third party compliments to your config.js using the moonphases listed in this module's README