search

Nolanus / ngx-page-scroll

Animated scrolling functionality for angular written in pure typescript
https://nolanus.github.io/ngx-page-scroll/
MIT License
479 stars 107 forks source link

"export 'ɵɵdefineInjectable' was not found in '@angular/core' #363

Closed andrefarzat closed 5 years ago

andrefarzat commented 5 years ago

Once the versions 5.x were unpublished from npm, we needed to upgrade to 6.x Following the small tutorial from the README.md, we are facing this issue (both on mac and windows machines):

Screen Shot 2019-06-03 at 19 05 22 Screen Shot 2019-06-03 at 19 16 03

The package.json is here: https://pastebin.com/uFgVXJH4

Digging on the code, if we change from ɵɵdefineInjectable to defineInjectable and from ɵɵinject to inject the code works. Can you see why this is happening ?

tfohlmeister commented 5 years ago

I can reproduce this error and confirm that downgrading ngx-page-scroll-core to 6.0.0 fixes this issue.

andrefarzat commented 5 years ago

Regarding the diff: https://github.com/Nolanus/ngx-page-scroll/compare/v6.0.0...v6.0.1 the main difference is the angular version which now is 8.x

I will downgrade to 6.0.0 ( forcing it on package.json ) while this isn't fixed

Nolanus commented 5 years ago

Hi,

v5 of ngx-page-scroll is still available via npm and can be installed via npm install ngx-page-scroll@5.0.1.

Cause for the reported problem is a change in the compiled bundles which I overlooked (see https://github.com/angular/angular/issues/30413). I'll release a new v6 version compiled using angular 7 tools shortly to fix this.

Nolanus commented 5 years ago

@andrefarzat, please check the behaviour with library v6.0.2 and let me know whether it's working.