search

Nolanus / ngx-page-scroll

Animated scrolling functionality for angular written in pure typescript
https://nolanus.github.io/ngx-page-scroll/
MIT License
477 stars 106 forks source link

Angular 9 #404

Closed achimha closed 3 years ago

achimha commented 4 years ago

Any plans to update the package for Angular 9?

Nolanus commented 4 years ago

Hi @achimha, the latest version if the library (v7) should already be able to work within an angular 9 environment. Please let me know in case you experience any issues.

achimha commented 4 years ago

No apparent issues but npm shows a version conflict warning and Angular 9 is now officially released.

S1nPur1ty commented 4 years ago

I am facing the same issue:

This likely means that the library (ngx-page-scroll-core) which declares NgxPageScrollCoreModule has not been processed correctly by ngcc, or is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.

Edit:

You should install both:

To make It work on your Angular 9 project.

damodog commented 3 years ago

I'm working on a project in Angular 9 and am having issues referencing the Node packages in my app.module file when importing.

Screenshot 2020-07-22 at 11 29 44

With ng serve running:

Screenshot 2020-07-22 at 11 22 14

If I change the path to look for the the package module files the error disappears:

Screenshot 2020-07-22 at 11 20 48

But the paths in the package files are now erroring?

Screenshot 2020-07-22 at 11 26 48

Angular CLI: 9.1.6 Node: 12.16.3 OS: darwin x64

Angular: 9.0.7 ... animations, common, compiler, compiler-cli, core, forms ... language-service, platform-browser, platform-browser-dynamic ... router Ivy Workspace: Yes

Package Version

@angular-devkit/architect 0.900.7 @angular-devkit/build-angular 0.900.7 @angular-devkit/build-ng-packagr 0.900.7 @angular-devkit/build-optimizer 0.900.7 @angular-devkit/build-webpack 0.900.7 @angular-devkit/core 9.0.7 @angular-devkit/schematics 9.1.6 @angular/cdk 9.2.3 @angular/cli 9.1.6 @angular/material 9.2.3 @ngtools/webpack 9.0.7 @schematics/angular 9.1.6 @schematics/update 0.901.6 ng-packagr 9.1.3 rxjs 6.5.5 typescript 3.7.5 webpack 4.41.2

Nolanus commented 3 years ago

Hi all. Sorry for the inconvenience, there was a problem with v7.0.2, resulting in the released files to be unusable for angular projects. v7.0.3 should fix this, please update to that version and let me know in case there any problems.