search

Nold360 / docker-borgserver

Dockerimage that runs a Borg backup server, accessible by ssh using publickey authentication
41 stars 23 forks source link

Use Borg version from Debian's buster-backports repository #11

Closed mweimerskirch closed 2 years ago

mweimerskirch commented 3 years ago

I noticed that the version of borgbackup that comes with Debian Buster is quite old: 1.1.9 (see https://packages.debian.org/buster/borgbackup). Given that there have been many improvements since then, I decided to upgrade to the version from Debian's backports repository instead. The version available here is 1.1.15 (see https://packages.debian.org/buster-backports/borgbackup).

Note that the version 1.1.9 included with Debian Buster already contains a fix for the index corruption bug that was fixed with 1.1.11 in the regular release (see https://metadata.ftp-master.debian.org/changelogs/main/b/borgbackup/borgbackup_1.1.9-2+deb10u1_changelog).

Not sure if this is of general interest, so feel free not to merge it. Nevertheless, it could be useful for some people so I decided to share it nevertheless.

Nold360 commented 3 years ago

Hi, thanks for your PR.

My first thought was: Why don't we upgrade to bullseye? It ships borgbackup 1.1.16 - I'll build a test image f

Nold360 commented 3 years ago

Here you go: https://github.com/Nold360/docker-borgserver/tree/upgrade/bullseye Image: nold360/borgserver:bullseye

Also fixed a little permission bug

Sadly I don't have a real testing setup anymore, since i upgraded to Kubernetes. But i did a quick test & everything looks fine so far.

mweimerskirch commented 3 years ago

My first thought was: Why don't we upgrade to bullseye? It ships borgbackup 1.1.16 - I'll build a test image

Good question. I've been using the backport for a couple of weeks and just sent it in today. I wasn't aware that Bullseye got released in the mean time 🙈

Here you go: https://github.com/Nold360/docker-borgserver/tree/upgrade/bullseye Image: nold360/borgserver:bullseye

Cool

Sadly I don't have a real testing setup anymore, since i upgraded to Kubernetes. But i did a quick test & everything looks fine so far.

I have a testing setup, but won't have time for the next two weeks. I'll give it a spin afterwards.

Nold360 commented 2 years ago

Will be fixed by #13