search

Noltari / pico-uart-bridge

Raspberry Pi Pico UART-USB bridge
MIT License
395 stars 70 forks source link

BUFFER SIZE=2560 line 20 in uart-bridge.c ? #21

Closed patfrench closed 7 months ago

patfrench commented 7 months ago

Hello,

I'm trying to understand the source code and while reading I saw this : https://github.com/Noltari/pico-uart-bridge/blob/ca81e5c242148a4e2462a10360f886cc8849a1fa/uart-bridge.c#L20

Why 2560 ?

Your project is awsome

Noltari commented 7 months ago

Hello,

I'm trying to understand the source code and while reading I saw this :

https://github.com/Noltari/pico-uart-bridge/blob/ca81e5c242148a4e2462a10360f886cc8849a1fa/uart-bridge.c#L20

Why 2560 ?

Your project is awsome

Someone suggested increasing it some time ago and I just did it :)

patfrench commented 7 months ago

Hello I'm sorry if this is a stupid question, but I thought we were limited to the UART buffer.

I just saw that the buffer is 256 so I guess a typo.

Thanks again

Noltari commented 7 months ago

Hello I'm sorry if this is a stupid question, but I thought we were limited to the UART buffer.

I just saw that the buffer is 256 so I guess a typo.

Thanks again

Yes, but you might not be able to forward that data to the USB host, so you might need to store more than the UART buffer.