NomadThanatos / readmoo-dl

106 stars 24 forks source link

PKG-007 (EPUB rule) #11

Open Kuan-Lun opened 2 years ago

Kuan-Lun commented 2 years ago

Mimetype 檔案應該只包含字串 "application/epub+zip" 並且不應該被壓縮。

NomadThanatos commented 2 years ago

Hi, could you please provide a example book or example content so I can look into it?

Like what is the expected content and what is the content readmoo-dl creating.

Kuan-Lun commented 2 years ago

How can I send the epub file to you?

The output epub-file does not pass the epub check tool [link].

ERROR (PKG-007) at "xxx.epub/mimetype": Mimetype file should only contain the string "application/epub+zip" and should not be compressed.

Maybe line 101 in "downloader.rb" adopts "compress" (I'm not sure). But the size of the unzipped output epub-file is larger than that of the output epub-file.

NomadThanatos commented 2 years ago

Thanks for you details, verified this issue in my book library.

I will check around to see how to fix it, but from my experience, this issue will not prevent you from reading those books.

NomadThanatos commented 2 years ago

I think this should resolve this issue, working on it.

And I think you could use this to fix previous books downloaded via readmoo-dl