Closed v3ect0rgames closed 1 week ago
Next time, make a new branch for each PR.
How would I do that, I’m not really used to groovy
Look at some of the other groovy scripts (like on the JEI Cleanup Branch) for some ideas.
Bug: Ores with same code name with different metadata, will only remove the overworld version, working on it now
Bug: Ores with same code name with different metadata, will only remove the overworld version, working on it now
In item("rl")
, just change it to item("rl", meta)
Im ready to merge it, I bugfixed and tested everything @IntegerLimit
Name Change: #271 also specifies the removal of unobtainable variants of ores from JEI, as well as vanilla ores, which is outside the scope of this PR at the moment.
Name Change: #271 also specifies the removal of unobtainable variants of ores from JEI, as well as vanilla ores, which is outside the scope of this PR at the moment.
The vanilla ores are already moved from jei. So this pull request should finish it
Name Change: #271 also specifies the removal of unobtainable variants of ores from JEI, as well as vanilla ores, which is outside the scope of this PR at the moment.
The vanilla ores are already moved from jei. So this pull request should finish it
you can merge it into main when the jei cleanup is done
for now merge it into the cleanup
and close #271
and close #271
Remember to make a new branch, from Nomi-CEu/main
or another development branch next time, instead of using your main
branch.
oh, because i left in end versions if you could get one of the versions
if you could get one version i left all in, because i was worried it would mess up the prospector screen
Just leave that part of #271 to me, I have some other changes outside of groovy scripts I would like to make related to that (cleaning up JEI pages like ore screens, etc.)
Removes unobtainable ores from jei.