Nomi-CEu / Nomi-CEu

Fork of Nomifactory, using Gregtech CEu and its related mods.
https://www.curseforge.com/minecraft/modpacks/nomi-ceu
GNU Lesser General Public License v3.0
184 stars 98 forks source link

Implement Parts of Issue #271 #762

Closed v3ect0rgames closed 1 week ago

v3ect0rgames commented 1 week ago

Removes unobtainable ores from jei.

IntegerLimit commented 1 week ago

Next time, make a new branch for each PR.

v3ect0rgames commented 1 week ago

How would I do that, I’m not really used to groovy

IntegerLimit commented 1 week ago

Look at some of the other groovy scripts (like on the JEI Cleanup Branch) for some ideas.

v3ect0rgames commented 1 week ago

Bug: Ores with same code name with different metadata, will only remove the overworld version, working on it now

IntegerLimit commented 1 week ago

Bug: Ores with same code name with different metadata, will only remove the overworld version, working on it now

In item("rl"), just change it to item("rl", meta)

v3ect0rgames commented 1 week ago

Im ready to merge it, I bugfixed and tested everything @IntegerLimit

IntegerLimit commented 1 week ago

Name Change: #271 also specifies the removal of unobtainable variants of ores from JEI, as well as vanilla ores, which is outside the scope of this PR at the moment.

v3ect0rgames commented 1 week ago

Name Change: #271 also specifies the removal of unobtainable variants of ores from JEI, as well as vanilla ores, which is outside the scope of this PR at the moment.

The vanilla ores are already moved from jei. So this pull request should finish it

IntegerLimit commented 1 week ago

Name Change: #271 also specifies the removal of unobtainable variants of ores from JEI, as well as vanilla ores, which is outside the scope of this PR at the moment.

The vanilla ores are already moved from jei. So this pull request should finish it

271 specifies the removal of unobtainable variants of ores from JEI, aka removing End Variant from an ore that cannot have the end variant obtainable.

v3ect0rgames commented 1 week ago

you can merge it into main when the jei cleanup is done

v3ect0rgames commented 1 week ago

for now merge it into the cleanup

v3ect0rgames commented 1 week ago

and close #271

IntegerLimit commented 1 week ago

and close #271

271 has more issues to solve. It specifies the removal of unobtainable variants of ores from JEI, aka removing End Variant from an ore that cannot have the end variant obtainable.

IntegerLimit commented 1 week ago

Remember to make a new branch, from Nomi-CEu/main or another development branch next time, instead of using your main branch.

v3ect0rgames commented 1 week ago

oh, because i left in end versions if you could get one of the versions

v3ect0rgames commented 1 week ago

if you could get one version i left all in, because i was worried it would mess up the prospector screen

IntegerLimit commented 1 week ago

Just leave that part of #271 to me, I have some other changes outside of groovy scripts I would like to make related to that (cleaning up JEI pages like ore screens, etc.)