search

NomicFoundation / edr

An Ethereum development runtime implementation that can be reused to build new developer tools.
MIT License
37 stars 3 forks source link

Rename abbreviated generic variables #146

Open Wodann opened 11 months ago

Wodann commented 11 months ago

Currently, we're using abbreviated generic type names, such as BE for "blockchain error" or SE for "state error". They should be renamed to their full equivalent. Format TBD: TBlockchainError or BLOCKCHAIN_ERROR.

@Wodann will discuss Slang's choice to decide format.

alcuadrado commented 11 months ago

I'm a big fan of naming these variables as BlockchainErrorT in typescript. The T, obviously, comes from Type.

Wodann commented 11 months ago

There is a downside to that, being that it's not instantly clear that you're dealing with a generic type, only by noticing the last character T