search

NomicFoundation / edr

An Ethereum development runtime implementation that can be reused to build new developer tools.
MIT License
32 stars 3 forks source link

ci: add workflows for PR reviews slack notifications #485

Closed fvictorio closed 4 weeks ago

fvictorio commented 1 month ago

These workflows will notify us on Slack when a PR review is requested or submitted. They use the jobs defined here: https://github.com/NomicFoundation/github-actions-workflows/tree/main/.github/workflows

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: b7963e105b99f881e081912b8dfd67391e511e7f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

fvictorio commented 1 month ago

I would personally like it, but maybe we can make it opt-in?

cc @alcuadrado

Wodann commented 1 month ago

I would personally like it, but maybe we can make it opt-in?

I just would like to avoid redundant notifications. I can also just disable my GitHub notifications and just focus on the Slack ones.

alcuadrado commented 1 month ago

It's opt-out within slack. You just need to mute your conversation with "Github review notifications".

alcuadrado commented 1 month ago

It's opt-out within slack. You just need to mute your conversation with "Github review notifications".

This doesn't work very well. You still get a red circle in the conversation. If you want, I can remove you from the workflow at the org level.

Personally, I haven't felt them as duplication, as these are much more specific than GitHub notifications, more like a call to action, while GH notifications keep me informed about everything.