search

NomicFoundation / edr

An Ethereum development runtime implementation that can be reused to build new developer tools.
MIT License
52 stars 8 forks source link

improvement: add chain id to error message #514

Closed fvictorio closed 3 months ago

fvictorio commented 3 months ago

This error is a bit better if it includes the remote chain id, because then adding it to the default hardfork histories (as done in https://github.com/NomicFoundation/hardhat/pull/5394) will be easier.

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: 3d6ea1b4538c1e04d17276922dea0f36d82d0e0c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

fvictorio commented 3 months ago

I generally don't add changesets for very minor changes in error messages, even if it's technically a user-facing change, because I don't think they are worth the noise in the release notes. But if you'd rather err on the side of adding one, I can do it, no problem.

Good point about the tests, I'll check.

fvictorio commented 3 months ago

Based on both grepping and the fact that they pass, I don't think we need to update any tests.