search

NomicFoundation / edr

An Ethereum development runtime implementation that can be reused to build new developer tools.
MIT License
52 stars 8 forks source link

fix: accept missing mix hashes in remote blocks #516

Closed fvictorio closed 3 months ago

fvictorio commented 3 months ago

See https://github.com/NomicFoundation/hardhat/discussions/5266#discussioncomment-9776377

I didn't add a test for this because neither Infura nor Alchemy support that creditcoin chain, and I don't think we should use public RPC URLs in our tests, since they don't tend to be very robust.

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 2e40c980741efc4045bdee95a9440b675a459ace

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------- | ----- | | @nomicfoundation/edr | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

jeremyjams commented 3 months ago

Thank you for the fix! Do you have any idea when you plan to release it? When EDR is released, would going through this "process" be enough to benefit from this fix from a fresh hardhat dependency?

fvictorio commented 3 months ago

@jeremyjams I guess we'll merge this today, and might release it later this week.

When EDR is released, would https://github.com/NomicFoundation/hardhat/pull/5087#issuecomment-2042188903 be enough to benefit from this fix from a fresh hardhat dependency?

Correct.

jeremyjams commented 3 months ago

Hi, do you have any update on that?

fvictorio commented 3 months ago

@jeremyjams sorry for taking longer than I expected, we just released this: https://github.com/NomicFoundation/edr/releases/tag/%40nomicfoundation%2Fedr%400.4.1

To upgrade to this version immediately, you can remove your node_modules directory and npm/yarn/pnpm lock file and reinstall your dependencies. Otherwise you can wait for the next Hardhat release which will automatically use the latest EDR version.

You can verify that you’re using the latest version by running the following command: npm ls @nomicfoundation/edr.

jeremyjams commented 3 months ago

Hello @fvictorio no problem, thank you for this release and your previous message :pray: (I'm sadly now facing another issue https://github.com/NomicFoundation/edr/issues/536)