NomicFoundation / edr

An Ethereum development runtime implementation that can be reused to build new developer tools.
MIT License
58 stars 14 forks source link

fix: return empty result for empty test suite #705

Closed agostbiro closed 1 month ago

agostbiro commented 1 month ago

Make sure we return an empty test suite result for empty test suites.

The fix changes the semantics of the TestFilter slightly, hence the need for the change to crates/edr_solidity_tests/tests/it/fork.rs, but since the TestFilter isn't exposed (it's only used in integration tests), I think this is ok.

The change in semantics is that previously we only returned results for a test suite if the test name filter also matched at least one test name in the test suite. Now we return an empty result instead if the path filter and suite name filter match, but the test name filter doesn't match.

Fixes https://github.com/NomicFoundation/edr/issues/702

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: be4cd10c12dbf488641e2b386b124d38f5ebfe7d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR