search

NomicFoundation / hardhat-ignition

Hardhat Ignition is a declarative deployment system that enables you to deploy your smart contracts without navigating the mechanics of the deployment process.
https://hardhat.org/ignition
MIT License
108 stars 26 forks source link

Exclude BNB Test Chain from zero fee configuration in gas fee logic #763

Closed kanej closed 5 months ago

kanej commented 6 months ago

Following on from: https://github.com/NomicFoundation/hardhat-ignition/pull/755

We should also exclude BNB Testnet Chain with chainId 97 and add a test to cover this case:

  1. Enhance this guard to include 97

https://github.com/NomicFoundation/hardhat-ignition/blob/355112935e732269abf05c8e775a1a146f634c94/packages/core/src/internal/execution/jsonrpc-client.ts#L643

  1. Add an equivalent test to this:

https://github.com/NomicFoundation/hardhat-ignition/blob/355112935e732269abf05c8e775a1a146f634c94/packages/core/test-integrations/new-api/internal/new-execution/jsonrpc-client.ts#L188

MukulKolpe commented 6 months ago

Hey @kanej, can I work on this issue?

kanej commented 6 months ago

Hey @kanej, can I work on this issue?

Absolutely @MukulKolpe, go for it.