NomicFoundation / hardhat-vscode

Solidity and Hardhat support for Visual Studio Code
https://hardhat.org
MIT License
163 stars 36 forks source link

Fix CI and foundry binary lookup for new installation directory #490

Closed antico5 closed 1 year ago

antico5 commented 1 year ago

2 weeks ago, the Foundry team updated the install scripts to use XDG_CONFIG_HOME if available, instead of HOME. Our CI box has it defined so tests were not passing, and I also updated the lookup function for forge binary in our server.

codecov-commenter commented 1 year ago

Codecov Report

Merging #490 (4074043) into development (9cfb24b) will decrease coverage by 0.23%. The diff coverage is n/a.

:exclamation: Current head 4074043 differs from pull request most recent head 7a0df87. Consider uploading reports for the commit 7a0df87 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@               Coverage Diff               @@
##           development     #490      +/-   ##
===============================================
- Coverage        53.52%   53.29%   -0.23%     
===============================================
  Files              187      187              
  Lines             4813     4813              
  Branches           791      791              
===============================================
- Hits              2576     2565      -11     
- Misses            2003     2010       +7     
- Partials           234      238       +4     

see 4 files with indirect coverage changes