search

NomicFoundation / hardhat-vscode

Solidity and Hardhat support for Visual Studio Code
https://hardhat.org
MIT License
163 stars 36 forks source link

feat: documentSymbol - project outline #499

Closed antico5 closed 7 months ago

antico5 commented 1 year ago

This PR is ready for review, but It's submitted over the semantic_highlighting branch because it's forked from that one. And this will make it easier to see the diff.

Closes #491

image

codecov-commenter commented 1 year ago

Codecov Report

Merging #499 (a887686) into semantic_highlighting (d85c38b) will decrease coverage by 0.24%. The diff coverage is n/a.

:exclamation: Current head a887686 differs from pull request most recent head d90068e. Consider uploading reports for the commit d90068e to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                    Coverage Diff                    @@
##           semantic_highlighting     #499      +/-   ##
=========================================================
- Coverage                  53.23%   53.00%   -0.24%     
=========================================================
  Files                        188      227      +39     
  Lines                       4824     5213     +389     
  Branches                     793      833      +40     
=========================================================
+ Hits                        2568     2763     +195     
- Misses                      2019     2213     +194     
  Partials                     237      237

see 41 files with indirect coverage changes

kanej commented 1 year ago

In local testing (i.e. the quickfix.sol file in the smoke test suite) I noticed if there is special characters (I think they are multi-byte unicode) the names in the outline are cut short.

image

Is this a slang error or a conversion error?

antico5 commented 1 year ago

In local testing (i.e. the quickfix.sol file in the smoke test suite) I noticed if there is special characters (I think they are multi-byte unicode) the names in the outline are cut short.

image

Is this a slang error or a conversion error?

Good catch. I even included utf8 characters in our test files (just with ñ, will try with more). We don't do the conversion ourselves anymore so I'll see what's happening

OmarTawfik commented 7 months ago

Closing in favour of #523