NomicFoundation / hardhat-vscode

Solidity and Hardhat support for Visual Studio Code
https://hardhat.org
MIT License
163 stars 36 forks source link

Add `foundryup` support for Windows #515

Open akshatmittal opened 10 months ago

akshatmittal commented 10 months ago

This PR adds support for foundryup on Windows, especially if forge is not available in path or conflicts with other globally installed packages.

codecov-commenter commented 10 months ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (development@6c7d5b6). Click here to learn what that means. The diff coverage is n/a.

:exclamation: Current head 085ded1 differs from pull request most recent head af82c8d. Consider uploading reports for the commit af82c8d to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@              Coverage Diff               @@
##             development     #515   +/-   ##
==============================================
  Coverage               ?   53.22%           
==============================================
  Files                  ?      188           
  Lines                  ?     4825           
  Branches               ?      793           
==============================================
  Hits                   ?     2568           
  Misses                 ?     2020           
  Partials               ?      237           
Xanewok commented 2 months ago

@kanej Do you think this fix looks acceptable? I don't have a Windows box but I imagine that installing through

curl -L https://foundry.paradigm.xyz | bash.

Now installs to .foundry rather than .cargo, so this makes sense, I think.