search

NomicFoundation / hardhat-vscode

Solidity and Hardhat support for Visual Studio Code
https://hardhat.org
MIT License
163 stars 36 forks source link

chore: report telemetry consent #540

Open antico5 opened 5 months ago

antico5 commented 5 months ago

This PR introduces two events sent to Google Analytics, without any client information, for when the user first responds to the "enable telemetry" popup, and any subsequent change to the setting via UI.

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (development@12bb234). Click here to learn what that means.

:exclamation: Current head 44f7f08 differs from pull request most recent head b183cc0. Consider uploading reports for the commit b183cc0 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #540 +/- ## ============================================== Coverage ? 52.65% ============================================== Files ? 228 Lines ? 5320 Branches ? 835 ============================================== Hits ? 2801 Misses ? 2281 Partials ? 238 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

antico5 commented 2 months ago

We're specifically anonymizing the consent response/change and that's why we're using a hardcoded user ID, right? That's just to gauge how many people are responding Y/N?

If the data reported is anonymous anyway, wouldn't we want to already know who changed the consent? We can sort of already understand who agreed (by inspecting the machine ID); this just prevents us from seeing when some machine ID stopped consenting (which is fine but wanted to bring it up).

Otherwise, looks good to me!

My understanding is that we want to anonymize this particular response because if the user answers no, we don't want to store their machine ID. Also for analytics purposes we only care about the number of users and not about what a specific user responded.