search

NomicFoundation / hardhat-vscode

Solidity and Hardhat support for Visual Studio Code
https://hardhat.org
MIT License
169 stars 39 forks source link

Upgrade to Slang 0.13.1 #545

Closed Xanewok closed 7 months ago

Xanewok commented 7 months ago

I wanted to focus on the upgrading the version with the least amount of changes to facilitate the review.

One change that I introduced is that I introduced CST node name checks in the SymbolVisitor to better convey which node we want to match, e.g. name node in the StateVariableDeclaration (instead of a possible second identifier in the = ... init part). Some CST node ranges were changed, so I had to modify the snapshot data.

Next step should probably include migrating to queries for both perf and completeness' sake (i.e. FunctionDefinition>FunctionName that can be either Identifier or a keyword).

It's worth noting that this version correctly parses contextual keywords (like from) and supports parsing EVM built-ins, so it should parse correctly a lot more code than the previous 0.10 version.

Part of https://github.com/NomicFoundation/slang/issues/639

socket-security[bot] commented 7 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@nomicfoundation/slang@0.13.1 filesystem, shell +9 54.4 MB nomic-foundation-publisher

🚮 Removed packages: npm/@nomicfoundation/slang@0.10.1

View full report↗︎

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (development@614c921). Click here to learn what that means.

:exclamation: Current head ff03ab3 differs from pull request most recent head afa6931. Consider uploading reports for the commit afa6931 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #545 +/- ## ============================================== Coverage ? 52.61% ============================================== Files ? 228 Lines ? 5318 Branches ? 835 ============================================== Hits ? 2798 Misses ? 2282 Partials ? 238 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.