search

NomicFoundation / hardhat-vscode

Solidity and Hardhat support for Visual Studio Code
https://hardhat.org
MIT License
163 stars 36 forks source link

[Feature] Go To Definition does not work or is not fully resolved #553

Open DrakeEvans opened 2 months ago

DrakeEvans commented 2 months ago

Feature: Go To Definition should support function definitions as well as fully resolve Definitions

Current Situation: Function definitions not supported, For supported symbols Go To Definition only goes to the nearest declaration not to the implementation

https://github.com/NomicFoundation/hardhat-vscode/assets/31104161/67496b24-9d93-4ea3-97ae-ecf30fd41b18

Proposed: Function definitions supported, Go To Definition fully resolves to implementation not nearest declaration

https://github.com/NomicFoundation/hardhat-vscode/assets/31104161/bf6ba5e8-30c1-4ae2-896d-a1fbfd3a0e72

DrakeEvans commented 2 months ago

The OptimalOutcome.mp4 is generated from using the Tools For Solidity extension

kanej commented 2 months ago

Hey @DrakeEvans, thanks for the reproduction videos they are always valued. Can you point me to to the repo you where using if its open source?

DrakeEvans commented 2 months ago

@kanej Yes you can see it at https://github.com/agora-finance/agora-dollar-evm-tests/blob/master/src/test/erc20-privilaged/TestMinting.t.sol

You will need to run forge install and npm i to make it work

DrakeEvans commented 2 months ago

Will need to run npm i inside of one submodule as well cd lib/agora-dollar-evm/ && npm i