NomicFoundation / hardhat-vscode

Solidity and Hardhat support for Visual Studio Code
https://hardhat.org
MIT License
163 stars 36 forks source link

Bump Slang to 0.14.2 #565

Closed Xanewok closed 1 month ago

Xanewok commented 2 months ago

This pulls in support for latest Solidity 0.8.25 and contains a bugfix that allows to correctly parse f.address for function pointers in the assembly; other than that, it's passing Sanctuary tests for mainnet and popular L2s like Arbitrum, BSC, Polygon or Optimism.

Hopefully this will get rid of the "Unsupported version" errors in Sentry that we were receiving lately; also the language coverage should be fairly complete now.

socket-security[bot] commented 2 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@nomicfoundation/slang@0.14.2 filesystem, shell +9 38.6 MB nomic-foundation-publisher

🚮 Removed packages: npm/@nomicfoundation/slang@0.14.0, npm/@nomicfoundation/solidity-language-server@0.8.2

View full report↗︎

Xanewok commented 2 months ago

It looks like Add label to new issue is failing again.

Xanewok commented 2 months ago

Great, thanks!

Do I understand correctly that the lockfile version bumps for the extension in https://github.com/NomicFoundation/hardhat-vscode/pull/565/commits/b268c5f2d9fa93e807ba28bda9964d3d8384efb0 are expected? I ran npm install after bumping the slang dep but it looked like the extension version needed updating as well.

If that's expected, it'd be great to merge and release a new extension with it, if that's fine with you :pray: We'll probably have to look into how we can automate the publishing process, so that it's not on you everytime. Thanks @kanej!

kanej commented 1 month ago

Great, thanks!

Do I understand correctly that the lockfile version bumps for the extension in b268c5f are expected? I ran npm install after bumping the slang dep but it looked like the extension version needed updating as well.

If that's expected, it'd be great to merge and release a new extension with it, if that's fine with you 🙏 We'll probably have to look into how we can automate the publishing process, so that it's not on you everytime. Thanks @kanej!

They are expected. @OmarTawfik and I are planning on a release on Wed 7th May (tomorrow).