search

NomicFoundation / hardhat

Hardhat is a development environment to compile, deploy, test, and debug your Ethereum software.
https://hardhat.org
Other
7.15k stars 1.37k forks source link

Remove the FILE parsing logic when parsing cli arguments #5338

Closed ChristopherDedominici closed 3 months ago

ChristopherDedominici commented 3 months ago

Implements the 2 points mentioned in this comment: https://github.com/NomicFoundation/hardhat/pull/5300#pullrequestreview-2094310723.

Point nr 1 in this commit: https://github.com/NomicFoundation/hardhat/pull/5338/commits/080450b635dded38a01fa6ad697aa07858dcd0e8 Without the logic to parse the FILE type, the function is no longer async. This has a cascade effect so a lot of async functions can now be converted to sync

Point nr 2 in this commit: https://github.com/NomicFoundation/hardhat/pull/5338/commits/3b1f69e3f44884e81e88c27774e10ced266c3ffd The logic for point nr 2 is already implemented, but I added an additional test to cover the scenario

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 11:18pm
changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: 3b1f69e3f44884e81e88c27774e10ced266c3ffd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR