NomicFoundation / hardhat

Hardhat is a development environment to compile, deploy, test, and debug your Ethereum software.
https://hardhat.org
Other
7.04k stars 1.36k forks source link

Optimize and Enable E2E tests on Windows #5339

Closed sisco0 closed 1 month ago

sisco0 commented 1 month ago

This pull request introduces several optimizations to the existing e2e-tests.yml workflow to improve the overall execution time and efficiency of our end-to-end (e2e) tests on GitHub Actions as required in #5247.

Changes Introduced:

No testing has been performed over the current solution.

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: dce45b3e6183da5202ef728f94bb4afdb2dd5faa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 8:58pm
alcuadrado commented 1 month ago

I'm a bit confused about this PR, it fails because you are trying to run a file that doesn't exist.

sisco0 commented 1 month ago

Reason behind was PowerShell scripts references, which are not currently present in the project. Instead of commiting the new PowerShell (.ps1) files, references about these have been removed. Re-factored the current source-code and pushed the commit for it. @alcuadrado

alcuadrado commented 1 month ago

Isn't this removing a comment about a bug without any reason? I don't think this has been fixed, is it?

sisco0 commented 1 month ago

Isn't this removing a comment about a bug without any reason? I don't think this has been fixed, is it?

Comment was restored as requested @alcuadrado . Agree on the given fact. Ideally, a reference to a Github Issue should be added for properly handling the case actively. This could be debugged in the future via https://github.com/nektos/act

alcuadrado commented 1 month ago

Thanks once again for submitting this PR, @sisco0. Unfortunately, we won't be able to prioritize this just yet. Our CI needs are pretty different in our main development branch, so we can't put much effort into this right now.