NomicFoundation / hardhat

Hardhat is a development environment to compile, deploy, test, and debug your Ethereum software.
https://hardhat.org
Other
7.22k stars 1.38k forks source link

Add isObject function, and move camelToKebabCase to hardhat-utils #5345

Closed sisco0 closed 4 months ago

sisco0 commented 4 months ago

Solves issue https://github.com/NomicFoundation/hardhat/issues/5305.

This Pull Request performs the following actions:

  1. Introduces a new utility function isObject
  2. Refactors the existing kebabToCamelCase function by moving it to the hardhat-utils package.

No test has been performed over the current proposal.

changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: 29424d105afef1e79da602a6df00e06790a055f0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 10:47pm
sisco0 commented 4 months ago

Solved conflicts.

kanej commented 4 months ago

Hey @sisco0, we really appreciate the PRs but issues tagged as v-next are against the next version of Hardhat. The work there is internal for the moment. The v-next part of the codebase is under rapid change guided by regular sync meetings. Hopefully this part of the codebase will have solidified enough to accept external PRs soon. In the meantime, if your looking to pick up an issue (and we really do appreciate all the effort) we would ask that you filter out those with the v-next label.