hook manager tests - Githubissues

NomicFoundation / hardhat

Hardhat is a development environment to compile, deploy, test, and debug your Ethereum software.

https://hardhat.org

Other

7k stars 1.36k forks source link

hook manager tests #5393

Closed kanej closed 2 weeks ago

kanej commented 3 weeks ago

Add unit tests around the HookManager in ./v-next/core/src/internal/Hook-Manager.ts.

It applies some small refactoring to the HookManager swapping in assertion instead of conditionals throwing errors, and replacing a plain Error with a specific HardhatError.

Resolves #5231.

TODO

[x] runHandlerChain
[x] runSequentialHandlers
[x] runParallelHandlers
[x] unregisterHandlers

changeset-bot[bot] commented 3 weeks ago

⚠️ No Changeset found

Latest commit: f9fa705a4e2fe81c724dead0764f19f0a1fc32cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
hardhat	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 21, 2024 9:18am