search

NomicFoundation / hardhat

Hardhat is a development environment to compile, deploy, test, and debug your Ethereum software.
https://hardhat.org
Other
7k stars 1.36k forks source link

buildGlobalParametersMap implementation & testing #5399

Closed schaable closed 2 weeks ago

schaable commented 3 weeks ago

Part of https://github.com/NomicFoundation/hardhat/issues/5379

This should be easy to review by going through it commit by commit.

Merge this after https://github.com/NomicFoundation/hardhat/pull/5390

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2024 2:20pm
changeset-bot[bot] commented 3 weeks ago

⚠️ No Changeset found

Latest commit: 0e1ba7a0cfcb24adb1854dda30995e953b20797f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

schaable commented 2 weeks ago

LGTM, but let's not forget about the naming issue

I've added an issue to track it.