search

NomicFoundation / hardhat

Hardhat is a development environment to compile, deploy, test, and debug your Ethereum software.
https://hardhat.org
Other
7k stars 1.36k forks source link

resolveGlobalArguments implementation & testing #5414

Closed schaable closed 1 week ago

schaable commented 2 weeks ago

Part of https://github.com/NomicFoundation/hardhat/issues/5379

This should be easier to review by reviewing each commit individually.

Merge this after https://github.com/NomicFoundation/hardhat/pull/5399

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 2:27pm
changeset-bot[bot] commented 2 weeks ago

⚠️ No Changeset found

Latest commit: 665a755469f337054bcb80d64bcba9d4c3c64aaf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

zoeyTM commented 2 weeks ago

@schaable now that https://github.com/NomicFoundation/hardhat/pull/5417 has been merged, this PR will need rebasing and will need to also follow the new name scheme. i.e. resolveGlobalArguments becomes resolveGlobalOptions, etc.

schaable commented 2 weeks ago

@schaable now that #5417 has been merged, this PR will need rebasing and will need to also follow the new name scheme. i.e. resolveGlobalArguments becomes resolveGlobalOptions, etc.

done!