search

NomicFoundation / hardhat

Hardhat is a development environment to compile, deploy, test, and debug your Ethereum software.
https://hardhat.org
Other
7k stars 1.36k forks source link

move parseTaskAndArguments into the tests as a temporary fix for tests #5424

Closed zoeyTM closed 1 week ago

zoeyTM commented 2 weeks ago

Fixes https://github.com/NomicFoundation/hardhat/issues/5410

Ideally, this PR would split the tests into appropriate tests of parseTask and parseTaskArguments, however, there are many tests and the logic for testing both is deeply intertwined in both. Since the underlying logic is the same, I decided to simply make parseTaskAndArguments a test-only function abstraction since I don't think it's worth the dev time right now to fully break out all the tests.

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 3:16pm
changeset-bot[bot] commented 2 weeks ago

⚠️ No Changeset found

Latest commit: ab95f71617f2c76b138038242c681aa8073af7c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR