search

NomicFoundation / hardhat

Hardhat is a development environment to compile, deploy, test, and debug your Ethereum software.
https://hardhat.org
Other
7.22k stars 1.38k forks source link

Forbid top-level-await #5454

Closed alcuadrado closed 3 months ago

alcuadrado commented 3 months ago

This PR adds a rule to eslint to forbid top-level-await.

We use it in two files, but we shouldn't use it anywhere else. They are the client's entry point and the index of hardhat, both initialize instances of the HRE.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 3:47pm
changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: ba1c8fda622e24ecf43789fc3a69b17a091c3ab1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR