Fix `hre` initialization

NomicFoundation / hardhat

Hardhat is a development environment to compile, deploy, test, and debug your Ethereum software.

https://hardhat.org

Other

7.04k stars 1.36k forks source link

Fix `hre` initialization #5485

Closed alcuadrado closed 2 weeks ago

alcuadrado commented 2 weeks ago

This PR fixes a bug I found, that prevented the builtin plugins from being loaded when a user was initializing the HRE with import "hardhat". This PR fixes that by ensuring that the HRE is always initialized using hardhat/hre.

The changes introduced here are, in order:

Introduced a failing test, showing the bug.
Refactor the initialization process to always use the hardhat/hre module.
Fix some unrelated failing test after the refactor.
Added an eslint rule to hardhat to avoid repeating that mistake.

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
hardhat	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 4, 2024 11:08pm

changeset-bot[bot] commented 2 weeks ago

⚠️ No Changeset found

Latest commit: c9a7d4db01f9275d47a9a66cbe16102967ec3b86

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR