search

NomicFoundation / hardhat

Hardhat is a development environment to compile, deploy, test, and debug your Ethereum software.
https://hardhat.org
Other
7.04k stars 1.36k forks source link

Include the builtin options as part of the global options & augment the types #5494

Closed schaable closed 1 week ago

schaable commented 1 week ago

This is a follow-up PR to #5470 based on discussions with Pato. In this PR:

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 5:33pm
changeset-bot[bot] commented 1 week ago

⚠️ No Changeset found

Latest commit: e09c0f472a1b5a647ad2443646592234288b71cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

schaable commented 1 week ago

I think that these changes won't initialize the HRE with the builtin global options when doing import "hardhat". There was a similar with plugins that I fixed in github.com//pull/5485

Done in https://github.com/NomicFoundation/hardhat/pull/5494/commits/88d8e5dfb3ebe1be930ddd34a66c45ef288e4688. I've also noticed that we were missing the init builtin option and config was incorrectly named configPath. It's fixed in https://github.com/NomicFoundation/hardhat/pull/5494/commits/c07d1b5eff58fd8ed54de83fd5a0c46d01f06f22 and https://github.com/NomicFoundation/hardhat/pull/5494/commits/e09c0f472a1b5a647ad2443646592234288b71cb