NomicFoundation / hardhat

Hardhat is a development environment to compile, deploy, test, and debug your Ethereum software.
https://hardhat.org
Other
7.2k stars 1.38k forks source link

Support for Diamonds #653

Closed mudgen closed 4 years ago

mudgen commented 4 years ago

It would be great if Builder provided support for deploying and upgrading diamonds. The Diamond Standard is here: https://github.com/ethereum/EIPs/issues/2535

Here is an example of a tool (in Python) that helps manage diamonds: https://github.com/lampshade9909/DiamondSetter

Blog post about that tool: http://joeyzacherl.com/2020/06/diamond-setter-ethereum-smart-contract-manager/

alcuadrado commented 4 years ago

Hey @mudgen,

Thanks for suggesting this.

Buidler is very opinionated so this wouldn't be a good fit for it. This would be a great fit for a plugin though.

If you or anyone is interested in creating one, here's a guide about how to do it, and here's a repo with all the needed boilerplate.

fzeoli commented 4 years ago

unopinionated* :P

On Thu, Jun 18, 2020 at 11:28 AM Patricio Palladino < notifications@github.com> wrote:

Hey @mudgen https://github.com/mudgen,

Thanks for suggesting this.

Buidler is very opinionated so this wouldn't be a good fit for it. This would be a great fit for a plugin though.

If you or anyone is interested in creating one, here's a guide about how to do it https://buidler.dev/advanced/building-plugins.html, and here's a repo with all the needed boilerplate https://github.com/nomiclabs/buidler-ts-plugin-boilerplate.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nomiclabs/buidler/issues/653#issuecomment-646054810, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABYV3UDXL7TSJWY6RPBDNDRXIP7ZANCNFSM4OBTKJEA .

mudgen commented 4 years ago

@alcuadrado Thank you! Do you know anyone who might be interested in making a plugin for this?

alcuadrado commented 4 years ago

I'm not familiar with this EIP nor the Diamond standard, so I'm afraid not.

Creating plugins is incredibly simple though. We can give you some guidance if you feel like doing it.

fzeoli commented 4 years ago

Plenty of community members in our Telegram group are building plugins, so you might be able to find someone there who wants to build it too https://t.me/BuidlerSupport

On Thu, Jun 18, 2020 at 1:31 PM Patricio Palladino notifications@github.com wrote:

I'm not familiar with this EIP nor the Diamond standard, so I'm afraid not.

Creating plugins is incredibly simple though. We can give you some guidance if you feel like doing it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nomiclabs/buidler/issues/653#issuecomment-646147355, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABYV3ROMJK5UKWTDOQVTP3RXI6MLANCNFSM4OBTKJEA .

mudgen commented 4 years ago

Thanks @alcuadrado and @fzeoli I appreciate it. I'll check with the Telegram group.

alcuadrado commented 4 years ago

Hey @mudgen, I'm closing this issue as this already supported by buidler-deploy. Feel free to open a new one.