Closed Exaxxion closed 3 years ago
@eutropius225 noted https://github.com/OmnifactoryDevs/DimensionalEdibles/pull/10#discussion_r575885708 that the BlockCakeBase::cakeFuel() could instead be made to return an Item, and https://github.com/OmnifactoryDevs/DimensionalEdibles/pull/10#discussion_r575886624 that the related method BlockCustomCake::determineCakeFuel() could be improved by caching the results to avoid recomputation unless the config value actually changes.
BlockCakeBase::cakeFuel()
Item
BlockCustomCake::determineCakeFuel()
This ticket is to remind us to investigate and potentially implement these optimizations.
@eutropius225 noted https://github.com/OmnifactoryDevs/DimensionalEdibles/pull/10#discussion_r575885708 that the
BlockCakeBase::cakeFuel()
could instead be made to return anItem
, and https://github.com/OmnifactoryDevs/DimensionalEdibles/pull/10#discussion_r575886624 that the related methodBlockCustomCake::determineCakeFuel()
could be improved by caching the results to avoid recomputation unless the config value actually changes.This ticket is to remind us to investigate and potentially implement these optimizations.