Nomifactory / ExtendedCrafting

Adds some new ways to craft items, as well as extra crafting items and utilities.
MIT License
2 stars 5 forks source link

Always register custom singularity oredict recipes #32

Open WaitingIdly opened 10 months ago

WaitingIdly commented 10 months ago

resolve #31 because https://github.com/Nomifactory/ExtendedCrafting/commit/fba62b60de217ad659c390c2b0ce23185ddf5c0c moved registering custom singularity recipes into preInit, any oredict created afterwards (eg crafttweaker) wouldnt register a singularity due to over-cautious validation checks. however, if a singularity is registered to an oredict that doesnt exist/has no items: nothing bad happens. in fact, this happens by default in ItemSingularity.java, since it tries to register a singularity to ingotArdite, and the dev environment doesnt have any ingotArdite. as such, this PR changes ItemSingularityCustom.java to always register oredict singularities, even when the oredict doesnt exist or has no items.

tested with

    S:custom_singularities <
        101;experience;ore:itemXP;b3f43b
     >

and both with and without

<ore:itemXP>.add(<minecraft:dirt>);