NonManifoldTopology / Topologic

Topologic is a software modelling library enabling hierarchical and topological representations of architectural spaces, buildings and artefacts through non-manifold topology.
GNU Affero General Public License v3.0
74 stars 19 forks source link

Bug Topology.AddApertures #29

Closed michalinadengusiak closed 2 years ago

michalinadengusiak commented 2 years ago

Your Environment

Context

I was following the 2nd tutorial on Topologic and decided to add apertures.

Expected Behavior

There should be apertures on the building.

Current Behavior

There are no apertures on the building.

Steps to Reproduce

  1. I connected Topology.AddApertures to a building.
  2. Under Aperture Topologies I connected the Topology of the geometry, I wanted as my apertures.

This is the GH definition:

AddApertures_Bug.zip

Possible Solution

Unfortunately, I don't have an idea, as to what might have caused the problem...

wassimj commented 2 years ago

Can you please screen shot your definition and post it here as an image? Thanks

michalinadengusiak commented 2 years ago

This is the definition: image

wassimj commented 2 years ago

I see the mistake. When you add Apertures to a topology like a CellComplex (e.g. a building), the Apertures are added to the corresponding Faces of the CellComplex not to the CellComplex itself. So, to get the apertures back, you need to first get the Faces of the CellComplex and then connect that to Topology.Apertures. Some faces (e.g. floors, ceilings, roofs) will not have apertures.

wassimj commented 2 years ago

Also, under normal circumstances (a 3D building with Apertures being windows and doors), your Aperture topology should be a Face not a Wire.

michalinadengusiak commented 2 years ago

Thank you so much for helping me and replying so quickly! Sorry, about the mix-up, but now I know for the future and will keep it in mind. 😊😉

wassimj commented 2 years ago

Excellent! Glad it was solved! You should try Topologic in Blender. It is sooo much more powerful than Grasshopper (and Free forever!)