search

NonStaticGH / CPathHostProject

This is a space where I develop Customizable Pathfinding plugin for UE5. Later on, I will also include my Engineering Thesis and documentation.
57 stars 13 forks source link

fix: WorldLocationFromTreeID() for condition that was causing exception #7

Closed Louspirit closed 1 year ago

Louspirit commented 1 year ago

Exception was "Depth higher than Octree Depth" in GetVoxelSizeByDepth().

Change is at line 391.

NonStaticGH commented 1 year ago

Hello, I'm sorry to say that I will not review/accept any github changes to my project, that would require me to treat this free plugin as my second job. If you found a bug, please provide reproduction steps. This function was unit tested on all proper treeID's in a depth 3 Octree, so please make sure you're passing a correct TreeID.

On Mon, Feb 27, 2023 at 4:26 PM Guillaume Escarieux < @.***> wrote:

Exception was "Depth higher than Octree Depth" in GetVoxelSizeByDepth().

Change is at line 391.

You can view, comment on, or merge this pull request online at:

https://github.com/NonStaticGH/CPathHostProject/pull/7 Commit Summary

File Changes

(1 file https://github.com/NonStaticGH/CPathHostProject/pull/7/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/NonStaticGH/CPathHostProject/pull/7, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3I6RJINKN44X7Q2WH5S6GTWZTBQ5ANCNFSM6AAAAAAVJRO3KI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Louspirit commented 1 year ago

You are welcome to take your time reviewing the PR. Isn't participation from the community a potential gain of time/scope/stability to the product you publicly released?😉

I just changed <= to < where I believe the only for loop followed by a GetVoxelSizeByDepth() method.

Because with this condition, let's say octree depth is set to 2: the for loop will let pass one time too many and set currDepth to 3. Which is over the octree depth, causing the error.

Louspirit commented 1 year ago

Can I suggest implementing labels for the Github repo? It could help sorting and prioritize PR and issues. In this case, something like BugFix.

NonStaticGH commented 1 year ago

You are wrong, and this is not the way to report bugs. Please provide the issue description and steps to reproduce, in engine, without making any changes in the code. You are free to modify your local copy of the plugin, but I will not be accepting pull requests.