Closed glynnforrest closed 9 years ago
Hi,
I looked your code, great idea ! I like the extraction of the logic into a service :)
In your class YumlCommand, You have two things I'd like you to change before merge :
Thanks for your contribution :)
Okay, all done.
CURLOPT_RETURNTRANSFER
has to go before CURLOPT_FILE
for some reason, so I moved that line to __construct()
. The toolbar button still works!
No problem! I'm very happy I can use it in my projects now.
Hello, thanks for this useful bundle!
I've added a console command so I can create and save the mapping images from the console. I'd like to generate mapping images in my jenkins builds.
I extracted the logic from
YumlController
to aYumlClient
class to aid reuse.