Console command - Githubissues

Nono1971 / doctrine-yuml-bundle

Bundle to visualise doctrine mapping with yuml in Symfony3

41 stars 12 forks source link

Closed glynnforrest closed 9 years ago

glynnforrest commented 9 years ago

Hello, thanks for this useful bundle!

I've added a console command so I can create and save the mapping images from the console. I'd like to generate mapping images in my jenkins builds.

I extracted the logic from YumlController to a YumlClient class to aid reuse.

Nono1971 commented 9 years ago

Hi,

I looked your code, great idea ! I like the extraction of the logic into a service :)

In your class YumlCommand, You have two things I'd like you to change before merge :

The Curl logic of downloadImage() method should go in the Curl class
Make as you did in your first commit : move logic into service, and only use YumlCommand class to call this logic with only few parameters.

Thanks for your contribution :)

glynnforrest commented 9 years ago

Okay, all done.

CURLOPT_RETURNTRANSFER has to go before CURLOPT_FILE for some reason, so I moved that line to __construct(). The toolbar button still works!

glynnforrest commented 9 years ago

No problem! I'm very happy I can use it in my projects now.