search

Nono1971 / doctrine-yuml-bundle

Bundle to visualise doctrine mapping with yuml in Symfony3
41 stars 12 forks source link

Compatibility with Symfony 5 #12

Closed Steveb-p closed 3 years ago

Steveb-p commented 4 years ago

Adjusts extension to work with Symfony 5.

Console command was not checked and will probably still require some work.

ahmed-bhs commented 3 years ago

@Steveb-p hey thank you for you pull request ! @Nono1971 could do you please take a quick look, we need to merge this pr asap. Cheers!

Nono1971 commented 3 years ago

Damn, I missed your PR !! Sorry, not actually working on symphony 5, I didn't notice the compatibility problem. I check that and merge it quick :)

Nono1971 commented 3 years ago

Well, great job :) Thanks a lot !!

Nono1971 commented 3 years ago

Well, I can't tag it right now, too much red in unit tests :D => Tests: 40, Assertions: 25, Errors: 26, Failures: 1. I'll tag 1.2 when all fixed... (I'll see depending of the amount of work if I revert the merge or not ^-^)

Steveb-p commented 3 years ago

@Nono1971 It's something I've made in spare time as a proof of concept for previous company, was happy to share in case anyone needed it.

I've cloned the lib again and looked through the tests that are failing - I think I'll be able to go through them tonight.