search

Nonononoki / Hendroid

Doujinshi Android App
https://f-droid.org/de/packages/org.nonononoki.hendroid/
Apache License 2.0
134 stars 10 forks source link

F-Droid can't build #24

Closed licaon-kter closed 3 years ago

licaon-kter commented 3 years ago

We used to remove some non-FOSS references and it built fine (accident?) but now...

> Task :app:compileReleaseJavaWithJavac
/home/vagrant/build/org.nonononoki.hendroid/app/src/main/java/me/devsaki/hentoid/util/GroupHelper.java:9: error: package com.google.firebase.crashlytics does not exist
import com.google.firebase.crashlytics.FirebaseCrashlytics;
                                      ^
/home/vagrant/build/org.nonononoki.hendroid/app/src/main/java/me/devsaki/hentoid/util/GroupHelper.java:104: error: cannot find symbol
            FirebaseCrashlytics crashlytics = FirebaseCrashlytics.getInstance();
            ^
  symbol:   class FirebaseCrashlytics
  location: class GroupHelper
/home/vagrant/build/org.nonononoki.hendroid/app/src/main/java/me/devsaki/hentoid/util/GroupHelper.java:104: error: cannot find symbol
            FirebaseCrashlytics crashlytics = FirebaseCrashlytics.getInstance();
                                              ^
  symbol:   variable FirebaseCrashlytics
  location: class GroupHelper
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
3 errors

...maybe a gradle flavor is needed?

Nonononoki commented 3 years ago

Removed some analytics from upstream and it should build now in newest version: https://github.com/Nonononoki/Hendroid/releases/tag/1.13.1.1

licaon-kter commented 3 years ago

Is https://github.com/Nonononoki/Hendroid/commit/9989c91d6c0012a714219f16b6e8de38c380fab9 not available from other repos?

ReF: https://f-droid.org/wiki/index.php?title=org.nonononoki.hendroid/lastbuild_165&oldid=288582

/pls reopen

Nonononoki commented 3 years ago

@licaon-kter Looks like the library (a fork) for file decompression is not yet in JCenter. Created a release with upstream version, but it should support all formats except 7z on Android. Created a new release for F-droid build.

Nonononoki commented 3 years ago

F-droid has built the latest version, closing issue.