Open licaon-kter opened 2 years ago
@Nonononoki
If you're looking for an alternative, I've considered
And ended up with SQLDelight. I found it easy to use, it's very well maintained and seemed to me the closes solution with the "easier" migration. I decided to bump it to a new major version instead of trying anything to migrate the previous database. My app already had an Export/Import option.
All commits related to this can be found in https://github.com/LeoColman/Petals/compare/b00f1e4b2c085613de0e2e6adce79b707d466191...3.0.2
I tried to keep the history as clean and clear as possible to facilitate migration for others.
@LeoColman I've decided to just include the library source directly.
@licaon-kter Any reason why my app was removed completely from F-droid? The page only shows a 404: https://f-droid.org/de/packages/org.nonononoki.hendroid/
@Nonononoki I believe it's because you've used Objectbox since build one. When you release a new build and change the Update Mode https://gitlab.com/fdroid/fdroiddata/-/commit/a8d558ff62e6411547466fc3a7b57c22b7c56aee#7f105fae0f21efd5cbbe93cf0918e0248eac7380_696_703
It will resume
In summary, only the builds with the tainted software were removed. In Hendroid's case it was all of them 🙈
@LeoColman Not the first time I merged upstream changes with non-FOSS plugins (https://github.com/Nonononoki/Hendroid/issues/24), but this is the first time app was completely removed. Usually F-droid just keep the page open with the older version.
That's the case here, however there isn't any older version for F-Droid to display, as all versions have the non-foss plugin
@Nonononoki yes. It's unfortunate :(
How will you include the source exactly?
@licaon-kter Already did with this commit 7336782ff43f6ba0be32b70b868bc86a083726e9 The plugin may be non-FOSS but the code is still Apache 2.0
Ok, didn't work. Building works but will get errors :(
What are the errors? Something binary related?
@LeoColman Yeah, it needs a binary library file. UnsatisfiedLinkError
That's what the plug-in downloads and adds to your app. It is proprietary as well 😔
ref: https://github.com/Nonononoki/Hendroid/blob/v1.16.9/build.gradle#L12 (since https://github.com/Nonononoki/Hendroid/commit/516ff9883db4dfd03f9e9d11681c3f675a9d7f92 )
Ref: https://github.com/objectbox/objectbox-java/issues/560
Ref: https://gitlab.com/fdroid/fdroidserver/-/merge_requests/1150