Nonprofit-Exchange-Hub / web-app

Nonprofit Circle (formerly Nonprofit Exchange Hub) A hub for the exchange of goods, information and connections for nonprofits of all sizes.
MIT License
29 stars 19 forks source link

web-app#307: new reset password styling #325

Closed marvinsjsu closed 1 year ago

marvinsjsu commented 1 year ago

https://github.com/orgs/Nonprofit-Exchange-Hub/projects/14/views/1?pane=issue&itemId=25095839

Dev Summary

Update the password reset page based on latest mock - password reset page

This commit includes:

Test Plan

repro steps:

  1. go to http://localhost:3000/set-new-password
  2. verify that the page reflects the latest mocks
  3. check if validation is applied when setting new password (error message is displayed and submit button disabled):
    • if password is less than minimum # of characters
    • if there's a mismatch of passwords entered
Screenshot 2023-04-24 at 11 57 18 PM

Resources

marvinsjsu commented 1 year ago

Thanks for the review, @esteban-gs! I've made changes to my PR and also left some responses.

marvinsjsu commented 1 year ago

Thanks again for the reviews, @esteban-gs!