Replace image and update copy on /signup-nonprofit

Nonprofit-Exchange-Hub / web-app

Nonprofit Circle (formerly Nonprofit Exchange Hub) A hub for the exchange of goods, information and connections for nonprofits of all sizes.

MIT License

29 stars 19 forks source link

Replace image and update copy on /signup-nonprofit #358

Closed marvinsjsu closed 7 months ago

marvinsjsu commented 1 year ago

The image used in /signup-nonprofit does not match what we have in our Figma mocks. This ticket is to replace this image with the correct asset, update the copy to include "ABOUT YOUR ORGANIZATION" text, and adjust the layout so it matches what's provided in Figma.

Current page:

Figma mock:

Figma - https://www.figma.com/file/K7DT5jYcLKRc9epmNrO0N7/UX---Dev-Handoff?type=design&node-id=1-5&mode=design&t=II3OZI8OgzhdP10A-0

junsuparkswe commented 1 year ago

@marvinsjsu Could I get access to the Figma file? I requested access to my email junsupark94@gmail.com

marvinsjsu commented 1 year ago

I've asked the design team for access on their channel #design-ux-ui ... hopefully, they'll be able to do this soon. If not, we can ping @Allyson Wright to help us with this.

junsuparkswe commented 1 year ago

@EtoKruto /signup has layout but is blank for me. And /signup-nonprofit is completely blank. Would you be able help me with this?

junsuparkswe commented 1 year ago

@marvinsjsu /signup and /signup-nonprofit are blank on the main branch. I think you're looking at Dennis' branch 288 feature which has the routes /signup-citizen and /signup-nonprofit.

@denniswangcodes I don't think I can proceed on this ticket until you complete your pull request for these signup pages. Could you let me know when that's done?

marvinsjsu commented 1 year ago

@junsupark94, you're right. Sorry for the confusion here, this is my bad. For this ticket, if you're ok with it @denniswangcodes, can we re-assign it to you since you're already working on the signup pages? I think @denniswangcodes tried to bring this up in our sync-up ... Again, so sorry for the confusion guys.

denniswangcodes commented 1 year ago

@marvinsjsu Sounds good, feel free to reassign to me since I'm already working on these signup pages and no problem at all. @junsupark94 Correct, the signup page should no longer be needed since we implemented the modal logic to be triggered instead. The PR feature branch, once merged, should reflect expected functionality. Appreciate your awareness on this.

marvinsjsu commented 1 year ago

thanks @denniswangcodes @junsupark94, this is re-assigned now.